Skip to content

Conversation

@dprotaso
Copy link
Member

No description provided.

@knative-prow knative-prow bot requested review from gauron99 and skonto October 19, 2025 03:30
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 19, 2025
@dprotaso dprotaso changed the title switch to stern for log collection. Also tar.gz the file [wip] switch to stern for log collection. Also tar.gz the file Oct 19, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 19, 2025
@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.14%. Comparing base (54868c2) to head (11444c1).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16167      +/-   ##
==========================================
+ Coverage   80.08%   80.14%   +0.06%     
==========================================
  Files         214      214              
  Lines       16940    16940              
==========================================
+ Hits        13566    13577      +11     
+ Misses       3015     3006       -9     
+ Partials      359      357       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Member Author

/hold cancel

@dprotaso dprotaso changed the title [wip] switch to stern for log collection. Also tar.gz the file switch to stern for log collection. Also tar.gz the file Oct 21, 2025
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2025
pod=$2;
gsub("/", "_", ns);
gsub("/", "_", pod);
system("mkdir -p " logdir "/" ns);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This captures logs into different files for each namespaces/pod

@dprotaso
Copy link
Member Author

/assign @dprotaso @dsimansk

Copy link
Member

@nader-ziada nader-ziada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of questions

@dprotaso
Copy link
Member Author

/hold added a test commit

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2025
@dprotaso
Copy link
Member Author

@dprotaso
Copy link
Member Author

removed WIP commit

@dprotaso
Copy link
Member Author

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2025
@nader-ziada
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2025
@knative-prow knative-prow bot merged commit 083ce78 into knative:main Oct 22, 2025
162 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants