-
Notifications
You must be signed in to change notification settings - Fork 1.2k
switch to stern for log collection. Also tar.gz the file #16167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16167 +/- ##
==========================================
+ Coverage 80.08% 80.14% +0.06%
==========================================
Files 214 214
Lines 16940 16940
==========================================
+ Hits 13566 13577 +11
+ Misses 3015 3006 -9
+ Partials 359 357 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
902b111 to
fad132e
Compare
d0290b2 to
6ae088f
Compare
|
/hold cancel |
test/e2e-common.sh
Outdated
| pod=$2; | ||
| gsub("/", "_", ns); | ||
| gsub("/", "_", pod); | ||
| system("mkdir -p " logdir "/" ns); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This captures logs into different files for each namespaces/pod
nader-ziada
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of questions
Co-authored-by: Nader Ziada <[email protected]>
|
/hold added a test commit |
11444c1 to
aceee4e
Compare
|
removed WIP commit |
|
/hold cancel |
|
/lgtm |
No description provided.